linux-kernel - Re: [PATCH] powerpc: remove unneeded if-checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 29 Apr 2023 06:25:56 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Tom Rix <trix@...hat.com>, "arnd@...db.de" <arnd@...db.de>,
        "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "npiggin@...il.com" <npiggin@...il.com>
CC:     "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] powerpc: remove unneeded if-checks



Le 29/04/2023 à 00:12, Tom Rix a écrit :
> For ppc64, gcc with W=1 reports
> arch/powerpc/platforms/cell/spu_base.c:330:17: error:
>    suggest braces around empty body in an 'if' statement [-Werror=empty-body]
>    330 |                 ;
>        |                 ^
> arch/powerpc/platforms/cell/spu_base.c:333:17: error:
>    suggest braces around empty body in an 'if' statement [-Werror=empty-body]
>    333 |                 ;
>        |                 ^
> 
> These if-checks do not do anything so remove them.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Fixes: 67207b9664a8 ("[PATCH] spufs: The SPU file system, base")

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>

> ---
>   arch/powerpc/platforms/cell/spu_base.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c
> index 7bd0b563e163..dea6f0f25897 100644
> --- a/arch/powerpc/platforms/cell/spu_base.c
> +++ b/arch/powerpc/platforms/cell/spu_base.c
> @@ -326,12 +326,6 @@ spu_irq_class_1(int irq, void *data)
>   	if (stat & CLASS1_STORAGE_FAULT_INTR)
>   		__spu_trap_data_map(spu, dar, dsisr);
>   
> -	if (stat & CLASS1_LS_COMPARE_SUSPEND_ON_GET_INTR)
> -		;
> -
> -	if (stat & CLASS1_LS_COMPARE_SUSPEND_ON_PUT_INTR)
> -		;
> -
>   	spu->class_1_dsisr = 0;
>   	spu->class_1_dar = 0;
>