linux-kernel - Re: [PATCH] riscv: fix sifive and thead section mismatches in errata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18779686-4e3a-c0a7-0e76-5bf1d151d2e2@infradead.org>
Date:   Sat, 29 Apr 2023 08:50:31 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Conor Dooley <conor@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Heiko Stuebner <heiko@...ech.de>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        linux-riscv@...ts.infradead.org, Evan Green <evan@...osinc.com>
Subject: Re: [PATCH] riscv: fix sifive and thead section mismatches in errata



On 4/29/23 02:50, Conor Dooley wrote:
> On Fri, Apr 28, 2023 at 09:35:30PM -0700, Randy Dunlap wrote:
>> When CONFIG_MODULES is set, __init_or_module becomes <empty>, but when
>> CONFIG_MODULES is not set, __init_or_module becomes __init.
>> In the latter case, it causes section mismatch warnings:
>>
>> WARNING: modpost: vmlinux.o: section mismatch in reference: riscv_fill_cpu_mfr_info (section: .text) -> sifive_errata_patch_func (section: .init.text)
>> WARNING: modpost: vmlinux.o: section mismatch in reference: riscv_fill_cpu_mfr_info (section: .text) -> thead_errata_patch_func (section: .init.text)
>>
>> It appears that CONFIG_MODULES not set is not tested very much.
> 
> I dunno if it the testing is *that* rare, because I'm not sure that the
> fixes tags below are correct. I think that it is actually:
> Fixes: bb3f89487fd9 ("RISC-V: hwprobe: Remove __init on probe_vendor_features()")
> That was only applied on 20/04.

Yeah, that Fixes: commit looks like the right one.
I'll send a v2.

Thanks.

> 
>> Fixes: a8e910168bba ("riscv: implement module alternatives")
>> Fixes: a35707c3d850 ("riscv: add memory-type errata for T-Head")
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Heiko Stuebner <heiko@...ech.de>
>> Cc: Paul Walmsley <paul.walmsley@...ive.com>
>> Cc: Palmer Dabbelt <palmer@...belt.com>
>> Cc: Albert Ou <aou@...s.berkeley.edu>
>> Cc: linux-riscv@...ts.infradead.org
>> ---
>>  arch/riscv/errata/sifive/errata.c |    8 +++-----
>>  arch/riscv/errata/thead/errata.c  |    6 +++---
>>  2 files changed, 6 insertions(+), 8 deletions(-)
>>

-- 
~Randy