linux-kernel - Re: [PATCH] iio: fix doc for iio_gts_find_sel_by_int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 1 May 2023 16:41:57 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Matti Vaittinen <mazziesaccount@...il.com>
Cc:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: fix doc for iio_gts_find_sel_by_int_time

On Fri, 21 Apr 2023 08:46:11 +0300
Matti Vaittinen <mazziesaccount@...il.com> wrote:

> The kerneldoc for iio_gts_find_sel_by_int_time() has an error.
> Documentation states that function is searching a selector for a HW-gain
> while it is searching a selector for an integration time.
> 
> Fix the documentation by saying the function is looking for a selector
> for an integration time.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
Given this is a very recent introduction and I don't like incorrect docs
sneaking in, I've applied this to the fixes-togreg branch of iio.git
(which just got rebased on char-misc-linus which now includes this code).

Thanks,

Jonathan

> ---
>  include/linux/iio/iio-gts-helper.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/iio/iio-gts-helper.h b/include/linux/iio/iio-gts-helper.h
> index dd64e544a3da..9cb6c80dea71 100644
> --- a/include/linux/iio/iio-gts-helper.h
> +++ b/include/linux/iio/iio-gts-helper.h
> @@ -135,7 +135,7 @@ static inline int iio_gts_find_int_time_by_sel(struct iio_gts *gts, int sel)
>  /**
>   * iio_gts_find_sel_by_int_time - find selector matching integration time
>   * @gts:	Gain time scale descriptor
> - * @gain:	HW-gain for which matching selector is searched for
> + * @time:	Integration time for which matching selector is searched for
>   *
>   * Return:	a selector matching given integration time or -EINVAL if
>   *		selector was not found.
> 
> base-commit: 52cc189b4fc6af6accc45fe7b7053d76d8724059