linux-kernel - Re: [PATCH AUTOSEL 6.3 34/44] media: cros-ec-cec: Don't exit early in .remove() callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230501152632.ccsvhl2c6ihuizcf@pengutronix.de>
Date:   Mon, 1 May 2023 17:26:32 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Hans Verkuil <hverkuil-cisco@...all.nl>, mchehab@...nel.org,
        bleung@...omium.org, groeck@...omium.org,
        kevin.chiu.17802@...il.com,
        scott_chao@...tron.corp-partner.google.com,
        zoey_wu@...tron.corp-partner.google.com,
        hellojacky0226@...mail.com, linux-media@...r.kernel.org,
        chrome-platform@...ts.linux.dev
Subject: Re: [PATCH AUTOSEL 6.3 34/44] media: cros-ec-cec: Don't exit early
 in .remove() callback

Hello,

On Sun, Apr 30, 2023 at 10:56:22PM -0400, Sasha Levin wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> [ Upstream commit 0ff7aee24e47beb4306ce050824b54147f2fabfa ]
> 
> Exiting early in remove without releasing all acquired resources yields
> leaks. Note that e.g. memory allocated with devm_zalloc() is freed after
> .remove() returns, even if the return code was negative.
> 
> While blocking_notifier_chain_unregister() won't fail and so the
> change is somewhat cosmetic, platform driver's .remove callbacks are
> about to be converted to return void. To prepare that, keep the error
> message but don't return early.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@...all.nl>
> Signed-off-by: Sasha Levin <sashal@...nel.org>

While I'm positive this change doesn't break anything, it also doesn't
fix anything and is only cosmetic (+ preparing a later change).

Unless you need it as a dependency I'd say, don't backport it for
stable.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)