linux-kernel - Re: [PATCH] imx8mn-var-som: dts: add SOM EEPROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <deaca10c-46ac-df19-5540-f1ae4c6fe9f7@linaro.org>
Date:   Mon, 1 May 2023 18:27:52 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Hugo Villeneuve <hugo@...ovil.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Hugo Villeneuve <hvilleneuve@...onoff.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] imx8mn-var-som: dts: add SOM EEPROM

On 01/05/2023 15:45, Hugo Villeneuve wrote:
> On Fri, 28 Apr 2023 15:06:22 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> 
>> On 27/04/2023 21:56, Hugo Villeneuve wrote:
>>> From: Hugo Villeneuve <hvilleneuve@...onoff.com>
>>
>> Thank you for your patch. There is something to discuss/improve.
>>
>>>
>>> The 4Kbit EEPROM located on the SOM contains hardware configuration
>>> options, manufacturing infos and ethernet MAC address.
>>
>> Use subject prefixes matching the subsystem (which you can get for
>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
>> your patch is touching).
>>
>>>
>>> Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>
>>> ---
>>>  arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 10 ++++++++++
>>>  1 file changed, 10 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
>>> index 9052b0d4b5b4..3ed396f41e46 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
>>> +++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
>>> @@ -30,6 +30,10 @@ reg_eth_phy: regulator-eth-phy {
>>>  		gpio = <&gpio2 9 GPIO_ACTIVE_HIGH>;
>>>  		enable-active-high;
>>>  	};
>>> +
>>> +	aliases {
>>
>> Keep nodes ordered.
>>
>>> +		eeprom_som = &eeprom_som;
>>
>> That's no valid alias. Which upstream kernel driver makes use of this?
> 
> Is "eeprom-som" ok?
> 
> No driver uses it for now..

None of them are valid if nothing uses them. There is also no clear
meaning of this alias to me. Why "som" should denote any alias in
upstream kernel?

Anyway, drop it as there are no users.

Best regards,
Krzysztof