linux-kernel - Re: [PATCH v3 21/38] parport: PC style parport depends on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 02 May 2023 15:40:47 +0200
From:   Niklas Schnelle <schnelle@...ux.ibm.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Alan Stern <stern@...land.harvard.edu>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        linux-kernel@...r.kernel.org,
        Linux-Arch <linux-arch@...r.kernel.org>,
        linux-pci@...r.kernel.org, Arnd Bergmann <arnd@...nel.org>
Subject: Re: [PATCH v3 21/38] parport: PC style parport depends on HAS_IOPORT

On Tue, 2023-03-14 at 15:12 +0100, Arnd Bergmann wrote:
> > On Tue, Mar 14, 2023, at 13:11, Niklas Schnelle wrote:
> > > > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> > > > not being declared. As PC style parport uses these functions we need to
> > > > handle this dependency.
> > > > 
> > > > Co-developed-by: Arnd Bergmann <arnd@...nel.org>
> > > > Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com>
> > 
> > > > 
> > > >  menuconfig PARPORT
> > > >  	tristate "Parallel port support"
> > > > -	depends on HAS_IOMEM
> > 
> > I would leave this dependency, or maybe make it 'HAS_IOMEM || HAS_IOPORT'.
> > at least the parport_atari driver uses MMIO instead of PIO.
> > 
> > > >  	help
> > > >  	  If you want to use devices connected to your machine's parallel port
> > > >  	  (the connector at the computer with 25 holes), e.g. printer, ZIP
> > > > @@ -42,7 +41,8 @@ if PARPORT
> > > > 
> > > >  config PARPORT_PC
> > > >  	tristate "PC-style hardware"
> > > > -	depends on ARCH_MIGHT_HAVE_PC_PARPORT || (PCI && !S390)
> > > > +	depends on ARCH_MIGHT_HAVE_PC_PARPORT
> > > > +	depends on HAS_IOPORT
> > > >  	help
> > > >  	  You should say Y here if you have a PC-style parallel port. All
> > > >  	  IBM PC compatible computers and some Alphas have PC-style
> > 
> > This would revert 66bcd06099bb ("parport_pc: Also enable driver for
> > PCI systems"), so I think this is wrong. You can drop the !S390
> > by adding HAS_IOPORT as a dependency, but the other line should still
> > be 
> > 
> >        depends on ARCH_MIGHT_HAVE_PC_PARPORT || PCI
> >     
> > 
> >     Arnd

Ok changed for v4. Just saw that commit even nicely references our lack
of I/O ports :-)