linux-kernel - Re: [PATCH v2 6/6] Input: cyttsp5 - implement proper sleep and wakeup procedures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d25cb52e-568c-637e-2708-e5d5d8b43b73@mweigand.net>
Date:   Tue, 2 May 2023 16:21:35 +0200
From:   Maximilian Weigand <mweigand@...igand.net>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org,
        Alistair Francis <alistair@...stair23.me>
Subject: Re: [PATCH v2 6/6] Input: cyttsp5 - implement proper sleep and wakeup
 procedures

Hi,

On 02.05.23 02:22, Dmitry Torokhov wrote:
> On Mon, May 01, 2023 at 01:30:10PM +0200, Maximilian Weigand wrote:
>>  struct cyttsp5 {
>>  	struct device *dev;
>>  	struct completion cmd_done;
>> +	struct completion cmd_command_done;
> 
> Why do we need separate comletion? Do you observe some additional
> traffic from the controller when powering it off and on?

I checked and indeed there is no overlap in the different command types,
so one completion will work. I will reformat correspondingly.

>> +static int __maybe_unused cyttsp5_suspend(struct device *dev)
>> +{
>> +	struct cyttsp5 *ts = dev_get_drvdata(dev);
>> +
>> +	if (!ts->is_wakeup_source)
> 
> I believe the idiomatic way to check this is to call
> device_may_wakeup().

Thanks for pointing that out. I will fix that, too.

Thanks for the feedback and best regards

Maximilian