linux-kernel - Re: [PATCH v2 4/9] eventfs: adding eventfs file, directory remove function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 May 2023 22:21:37 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ajay Kaher <akaher@...are.com>, rostedt@...dmis.org,
        mhiramat@...nel.org, shuah@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, chinglinyu@...gle.com,
        namit@...are.com, srivatsab@...are.com, srivatsa@...il.mit.edu,
        amakhalov@...are.com, vsirnapalli@...are.com, tkundu@...are.com,
        er.ajay.kaher@...il.com, Ajay Kaher <akaher@...are.com>
Subject: Re: [PATCH v2 4/9] eventfs: adding eventfs file, directory remove
 function

Hi Ajay,

kernel test robot noticed the following build warnings:

[auto build test WARNING on shuah-kselftest/next]
[also build test WARNING on shuah-kselftest/fixes linus/master rostedt-trace/for-next v6.3 next-20230428]
[cannot apply to rostedt-trace/for-next-urgent]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ajay-Kaher/eventfs-introducing-struct-tracefs_inode/20230502-192949
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
patch link:    https://lore.kernel.org/r/1683026600-13485-5-git-send-email-akaher%40vmware.com
patch subject: [PATCH v2 4/9] eventfs: adding eventfs file, directory remove function
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20230502/202305022234.nOgIYubz-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/9a36b39da0c3fbfe15a3c3a0ed71b52013bac292
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ajay-Kaher/eventfs-introducing-struct-tracefs_inode/20230502-192949
        git checkout 9a36b39da0c3fbfe15a3c3a0ed71b52013bac292
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash fs/tracefs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305022234.nOgIYubz-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/tracefs/event_inode.c:379:6: warning: no previous prototype for 'eventfs_remove_rec' [-Wmissing-prototypes]
     379 | void eventfs_remove_rec(struct eventfs_file *ef)
         |      ^~~~~~~~~~~~~~~~~~
   fs/tracefs/event_inode.c:58:13: warning: 'eventfs_up_read' defined but not used [-Wunused-function]
      58 | static void eventfs_up_read(struct rw_semaphore *eventfs_rwsem)
         |             ^~~~~~~~~~~~~~~
   fs/tracefs/event_inode.c:47:13: warning: 'eventfs_down_read' defined but not used [-Wunused-function]
      47 | static void eventfs_down_read(struct rw_semaphore *eventfs_rwsem)
         |             ^~~~~~~~~~~~~~~~~
   fs/tracefs/event_inode.c:31:29: warning: 'eventfs_dentry_to_rwsem' defined but not used [-Wunused-function]
      31 | static struct rw_semaphore *eventfs_dentry_to_rwsem(struct dentry *dentry)
         |                             ^~~~~~~~~~~~~~~~~~~~~~~


vim +/eventfs_remove_rec +379 fs/tracefs/event_inode.c

   371	
   372	/**
   373	 * eventfs_remove_rec - remove eventfs dir or file from list
   374	 * @ef: a pointer to eventfs_file to be removed.
   375	 *
   376	 * This function recursively remove eventfs_file which
   377	 * contains info of file or dir.
   378	 */
 > 379	void eventfs_remove_rec(struct eventfs_file *ef)
   380	{
   381		struct eventfs_file *ef_child, *n;
   382	
   383		if (!ef)
   384			return;
   385	
   386		if (ef->ei) {
   387			/* search for nested folders or files */
   388			list_for_each_entry_safe(ef_child, n, &ef->ei->e_top_files, list) {
   389				eventfs_remove_rec(ef_child);
   390			}
   391			kfree(ef->ei);
   392		}
   393	
   394		if (ef->created && ef->dentry) {
   395			d_invalidate(ef->dentry);
   396			dput(ef->dentry);
   397		}
   398		list_del(&ef->list);
   399		kfree(ef->name);
   400		kfree(ef);
   401	}
   402	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests