linux-kernel - Re: [PATCH v3 2/3] mfd: axp20x: Add support for AXP15060 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230503120759.6fd6a7a9@donnerap.cambridge.arm.com>
Date:   Wed, 3 May 2023 12:07:59 +0100
From:   Andre Przywara <andre.przywara@....com>
To:     Lee Jones <lee@...nel.org>
Cc:     Shengyu Qu <wiagn233@...look.com>, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, wens@...e.org,
        lgirdwood@...il.com, broonie@...nel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        conor.dooley@...rochip.com,
        Martin Botka <martin.botka@...ainline.org>
Subject: Re: [PATCH v3 2/3] mfd: axp20x: Add support for AXP15060 PMIC

On Wed, 26 Apr 2023 15:27:40 +0100
Lee Jones <lee@...nel.org> wrote:

Hi Lee,

I see this patch in Linus' tree, but something must have gone wrong here,
can you please check? See below ...

> On Fri, 21 Apr 2023, Shengyu Qu wrote:
> 
> > The AXP15060 is a PMIC chip produced by X-Powers, and could be connected
> > via an I2C bus.
> > 
> > Describe the regmap and the MFD bits, along with the registers exposed
> > via I2C. Eventually advertise the device using a new compatible string
> > and add support for power off the system.
> > 
> > The driver would disable PEK function if IRQ is not configured in device
> > tree, since some boards (For example, Starfive Visionfive 2) didn't
> > connect IRQ line of PMIC to SOC.
> > 
> > GPIO function isn't enabled in this commit, since its configuration
> > operation is different from any existing AXP PMICs and needs
> > logic modification on existing driver. GPIO support might come in later
> > patches.
> > 
> > ---  
> 
> You must not use these above the tags or Git will drop them.
> 
> > Changes since v2:
> >  - Rebase to AXP313a series v10 [1] + newest (20230420) -next branch

So this patch was based on the AXP313a series, but I don't see that in
Linus' tree (or in any of your trees, if I have checked correctly).
There must have been a conflict, as this [PATCH v3 2/3] diff actually lists
the axp313a entry in the context lines.

> >  - Add axp_regulator_only_cells rather than directly using axp806_cells
> >    for cases that IRQ line isn't connected.
> > 
> > Changes since v1:
> >  - Nothing
> > 
> > [1] https://lore.kernel.org/linux-sunxi/20230401001850.4988-1-andre.przywara@arm.com/
> > 
> > Signed-off-by: Shengyu Qu <wiagn233@...look.com>
> > ---  
> 
> Put change-logs here instead.
> 
> >  drivers/mfd/axp20x-i2c.c   |   2 +
> >  drivers/mfd/axp20x.c       | 107 +++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/axp20x.h |  85 +++++++++++++++++++++++++++++
> >  3 files changed, 194 insertions(+)  
> 
> I manually added the missing tags for this and the DT patch and applied.

So this patch doesn't list any tags aside from Shengyu's
Signed-off-by. The patch in Linus' tree list a Reviewed-by: from
Krzysztof, which I don't see anywhere in the thread, he just reviewed the
binding patch, AFAICT. I see your tentative R-b: on v2, but with the
request to rebase and resend, which he did with v3. The applied patch
looks like v3, but not on the base commit this was send against.

So I am slightly confused, and am also wondering what happened to the
AXP313a patches? I see the binding patch merged, but not the MFD part,
even though you replied saying so.

Cheers,
Andre