linux-kernel - Re: [PATCH] rust: bindings: fix sorting of rust/bindings/bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 3 May 2023 13:08:12 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Benno Lossin <benno.lossin@...ton.me>
Cc:     materoy@...ton.me, Miguel Ojeda <ojeda@...nel.org>,
        Alex Gaynor <alex.gaynor@...il.com>,
        Wedson Almeida Filho <wedsonaf@...il.com>,
        Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        Alice Ryhl <aliceryhl@...gle.com>,
        Martin Rodriguez Reboredo <yakoyoku@...il.com>,
        rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: bindings: fix sorting of rust/bindings/bindings_helper.h's
 #includes

On Wed, May 3, 2023 at 12:45 PM Benno Lossin <benno.lossin@...ton.me> wrote:
>
> A couple of nits for the commit message (these can be
> applied by Miguel when picking the patch, if he agrees):

Given this is one of the "get yourself familiarized with the kernel's
development process" issues that I create from time to time, it is a
good opportunity for Roy to fix those and send a v2.

Roy, could you please do that? Please pass `-v2` to `git format-patch`
when you do so, then also collect the two `Reviewed-by`s you got and
put them above your `Signed-off-by`.

> - capitalize 'Rust',
> - add a `.` at the end,
> - remove the newline between the tags.

Also: typo "idoms" -> "idioms", and the title could be improved to:

    rust: bindings: sort `#include`s of `bindings_helper.h`

since "rust/bindings" is already given by the prefixes etc.

However, what does it mean "...and rust idoms"? This is C code, not
Rust code, and thus it should follow kernel C idioms (which, in some
cases, do sort the `#include`s too, so that is fine).

Perhaps remove that bit, or say instead "Rust subsystem idioms"
instead (since we do want to keep them sorted :)

Thanks!

Cheers,
Miguel