linux-kernel - RE: [EXTERNAL] Re: [PATCH v1 3/5] firmware: tasdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82b9ac35631a4c4993dd2cd75f137273@ti.com>
Date:   Thu, 4 May 2023 13:55:21 +0000
From:   "Ding, Shenghao" <shenghao-ding@...com>
To:     Mark Brown <broonie@...nel.org>
CC:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "Lu, Kevin" <kevin-lu@...com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Xu, Baojun" <x1077012@...com>, "Gupta, Peeyush" <peeyush@...com>,
        "Navada Kanyana, Mukund" <navada@...com>,
        "gentuser@...il.com" <gentuser@...il.com>,
        "Shenghao Ding" <13916275206@....com>
Subject: RE: [EXTERNAL] Re: [PATCH v1 3/5] firmware: tasdevice_fmw: tasdevice
 firmware loading lib

Hi Broonie
Thanks for your comments.
In fact, we have a dilemma whether to put the code into firmware folder or sound/soc/codecs.
As you know, most cases are audio-related application,  such as a pure audio device or 
audio2haptics device, keeping the tasdevice-firmware lib into sound/soc/codecs would make sense.
However, in other cases, tasdevice(such as tas2781) can be used  as pure haptic to drive the Motor.
moving the lib into firmware folder would make sense, although such an application is a niche.
Would you be so kind and give some comments on it? Thanks.

BR
Shenghao Ding
-----Original Message-----
From: Mark Brown <broonie@...nel.org> 
Sent: Wednesday, May 3, 2023 8:28 AM
To: Shenghao Ding <13916275206@....com>
Cc: lgirdwood@...il.com; perex@...ex.cz; pierre-louis.bossart@...ux.intel.com; Lu, Kevin <kevin-lu@...com>; Ding, Shenghao <shenghao-ding@...com>; alsa-devel@...a-project.org; linux-kernel@...r.kernel.org; Xu, Baojun <x1077012@...com>; Gupta, Peeyush <peeyush@...com>; Navada Kanyana, Mukund <navada@...com>; gentuser@...il.com
Subject: [EXTERNAL] Re: [PATCH v1 3/5] firmware: tasdevice_fmw: tasdevice firmware loading lib

On Tue, May 02, 2023 at 01:32:35PM +0800, Shenghao Ding wrote:
> Create tasdevice firmware lib.

>  drivers/firmware/Kconfig            |    1 +
>  drivers/firmware/Makefile           |    1 +
>  drivers/firmware/ti/Kconfig         |    5 +
>  drivers/firmware/ti/Makefile        |    3 +
>  drivers/firmware/ti/tasdevice-fmw.c | 2380 
> +++++++++++++++++++++++++++
>  5 files changed, 2390 insertions(+)

Given how large this part of the code for these devices is it definitely makes sense to split it into a separate commit like you've done but are there any non-audio devices in this series which will share the same firmware style?  If not then it probably makes sense to keep the code in sound/soc/codecs, though a separate file would still make sense.

There's some devices that do keep firmware interface code in the firmware directory but in those cases the devices have other, non-audio, functionality which also uses the firmware (eg, always on monitoring) but I've not seen any of the tas devices like that.  If there are some then the split you've made here makes sense.