linux-kernel - Re: [EXTERNAL] Re: [PATCH v1 3/5] firmware: tasdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZFO64aZtVGNkNpZW@finisterre.sirena.org.uk>
Date:   Thu, 4 May 2023 23:02:09 +0900
From:   Mark Brown <broonie@...nel.org>
To:     "Ding, Shenghao" <shenghao-ding@...com>
Cc:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "Lu, Kevin" <kevin-lu@...com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Xu, Baojun" <x1077012@...com>, "Gupta, Peeyush" <peeyush@...com>,
        "Navada Kanyana, Mukund" <navada@...com>,
        "gentuser@...il.com" <gentuser@...il.com>,
        Shenghao Ding <13916275206@....com>
Subject: Re: [EXTERNAL] Re: [PATCH v1 3/5] firmware: tasdevice_fmw: tasdevice
 firmware loading lib

On Thu, May 04, 2023 at 01:55:21PM +0000, Ding, Shenghao wrote:

> In fact, we have a dilemma whether to put the code into firmware folder or sound/soc/codecs.
> As you know, most cases are audio-related application,  such as a pure audio device or 
> audio2haptics device, keeping the tasdevice-firmware lib into sound/soc/codecs would make sense.
> However, in other cases, tasdevice(such as tas2781) can be used  as pure haptic to drive the Motor.
> moving the lib into firmware folder would make sense, although such an application is a niche.
> Would you be so kind and give some comments on it? Thanks.

That sounds similar to the other examples where you've got some
non-audio applications and keeping things in firmware as you've done
makes sense.  If you resend then mentioning this in the commit message
would be helpful.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)