[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 5 May 2023 19:51:08 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Yassine Oudjana <yassine.oudjana@...il.com>,
Robert Foss <rfoss@...nel.org>,
Todor Tomov <todor.too@...il.com>,
Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Hans Verkuil <hansverk@...co.com>
Cc: Yassine Oudjana <y.oudjana@...tonmail.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: msm8996: Add CAMSS power domain and
power-domain-names to CAMSS
On 03/05/2023 09:25, Yassine Oudjana wrote:
> From: Yassine Oudjana <y.oudjana@...tonmail.com>
>
> Add the CAMSS power domain as well as power-domain-names for all CAMSS power domains.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
You should explain why you are adding it.
>
> Signed-off-by: Yassine Oudjana <y.oudjana@...tonmail.com>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 30f6ebc4bd11..0168a086f57d 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -2118,7 +2118,9 @@ camss: camss@...000 {
> "vfe0",
> "vfe1";
> power-domains = <&mmcc VFE0_GDSC>,
> - <&mmcc VFE1_GDSC>;
> + <&mmcc VFE1_GDSC>,
> + <&mmcc CAMSS_GDSC>;
> + power-domain-names = "vfe0", "vfe1", "camss";
> clocks = <&mmcc CAMSS_TOP_AHB_CLK>,
> <&mmcc CAMSS_ISPIF_AHB_CLK>,
> <&mmcc CAMSS_CSI0PHYTIMER_CLK>,
Best regards,
Krzysztof
Powered by blists - more mailing lists