linux-kernel - RE: [PATCH v6] usb: dwc3: core: add support for realtek SoCs custom's global register start address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2ddb17c182a42be9fc22afa85669695@realtek.com>
Date:   Sat, 6 May 2023 04:14:45 +0000
From:   Stanley Chang[昌育德] 
        <stanley_chang@...ltek.com>
To:     Thinh Nguyen <Thinh.Nguyen@...opsys.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v6] usb: dwc3: core: add support for realtek SoCs custom's global register start address

Hi Thinh,

> > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index
> > 0beaab932e7d..278cd1c33841 100644
> > --- a/drivers/usb/dwc3/core.c
> > +++ b/drivers/usb/dwc3/core.c
> > @@ -1800,6 +1800,17 @@ static int dwc3_probe(struct platform_device
> *pdev)
> >       dwc_res = *res;
> >       dwc_res.start += DWC3_GLOBALS_REGS_START;
> >
> > +     if (dev->of_node) {
> > +             struct device_node *parent =
> > + of_get_parent(dev->of_node);
> > +
> > +             if (of_device_is_compatible(parent, "realtek,rtd-dwc3"))
> > + {
> 
> Is your platform already released or is it still under development? Just curious
> since the compatible string isn't fixed. Is it going to be changed in the future?

Yes, our platform is released.
In our driver (the parent of the dwc3 driver), we used the compatible name "Realtek,dwc3".
To support this patch, I will add an alternative name "Realtek,rtd-dwc3" to our driver.

Thanks,
Stanley