lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202305061212.EPgEMLXl-lkp@intel.com>
Date:   Sat, 6 May 2023 12:27:18 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ondrej Zary <linux@...y.sk>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Sergey Shtylyov <s.shtylyov@....ru>
Subject: drivers/ata/pata_parport/frpw.c:234 frpw_test_proto() warn:
 inconsistent indenting

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   2e1e1337881b0e9844d687982aa54b31b1269b11
commit: 5f1145d8304f93286be774482db6298c40dfe812 ata: pata_parport: use dev_* instead of printk
date:   6 weeks ago
config: x86_64-randconfig-m001-20230501 (https://download.01.org/0day-ci/archive/20230506/202305061212.EPgEMLXl-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305061212.EPgEMLXl-lkp@intel.com/

New smatch warnings:
drivers/ata/pata_parport/frpw.c:234 frpw_test_proto() warn: inconsistent indenting

Old smatch warnings:
drivers/ata/pata_parport/frpw.c:239 frpw_test_proto() warn: inconsistent indenting

vim +234 drivers/ata/pata_parport/frpw.c

^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  225  
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  226  {       int     j, k, r;
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  227  	int	e[2] = {0,0};
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  228  
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  229  	if ((pi->private>>1) != pi->port)
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  230  	   pi->private = frpw_test_pnp(pi) + 2*pi->port;
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  231  
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  232  	if (((pi->private%2) == 0) && (pi->mode > 2)) {
5f1145d8304f93 drivers/ata/pata_parport/frpw.c Ondrej Zary    2023-02-18  233  		dev_dbg(&pi->dev, "frpw: Xilinx does not support mode %d\n", pi->mode);
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16 @234  	   return 1;
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  235  	}
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  236  
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  237  	if (((pi->private%2) == 1) && (pi->mode == 2)) {
5f1145d8304f93 drivers/ata/pata_parport/frpw.c Ondrej Zary    2023-02-18  238  		dev_dbg(&pi->dev, "frpw: ASIC does not support mode 2\n");
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  239  	   return 1;
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  240  	}
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  241  
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  242  	frpw_connect(pi);
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  243  	for (j=0;j<2;j++) {
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  244                  frpw_write_regr(pi,0,6,0xa0+j*0x10);
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  245                  for (k=0;k<256;k++) {
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  246                          frpw_write_regr(pi,0,2,k^0xaa);
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  247                          frpw_write_regr(pi,0,3,k^0x55);
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  248                          if (frpw_read_regr(pi,0,2) != (k^0xaa)) e[j]++;
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  249                          }
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  250                  }
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  251  	frpw_disconnect(pi);
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  252  
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  253  	frpw_connect(pi);
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  254          frpw_read_block_int(pi,scratch,512,0x10);
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  255          r = 0;
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  256          for (k=0;k<128;k++) if (scratch[k] != k) r++;
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  257  	frpw_disconnect(pi);
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  258  
5f1145d8304f93 drivers/ata/pata_parport/frpw.c Ondrej Zary    2023-02-18  259  	dev_dbg(&pi->dev, "frpw: port 0x%x, chip %ld, mode %d, test=(%d,%d,%d)\n",
a4f2ff92ed4a03 drivers/ata/pata_parport/frpw.c Ondrej Zary    2023-02-18  260  	       pi->port, (pi->private%2), pi->mode, e[0], e[1], r);
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  261  
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  262          return (r || (e[0] && e[1]));
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  263  }
^1da177e4c3f41 drivers/block/paride/frpw.c     Linus Torvalds 2005-04-16  264  

:::::: The code at line 234 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ