linux-kernel - RE: [PATCH v2 2/3] usb: chipidea: imx: support disabling runtime-pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PA4PR04MB96405EE2468555EA900B340189739@PA4PR04MB9640.eurprd04.prod.outlook.com>
Date:   Sat, 6 May 2023 09:02:39 +0000
From:   Jun Li <jun.li@....com>
To:     Francesco Dolcini <francesco@...cini.it>,
        Luca Ceresoli <luca.ceresoli@...tlin.com>
CC:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "festevam@...il.com" <festevam@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Francesco Dolcini <francesco.dolcini@...adex.com>,
        Xu Yang <xu.yang_2@....com>
Subject: RE: [PATCH v2 2/3] usb: chipidea: imx: support disabling runtime-pm



> -----Original Message-----
> From: Francesco Dolcini <francesco@...cini.it>
> Sent: Friday, May 5, 2023 7:00 PM
> To: Luca Ceresoli <luca.ceresoli@...tlin.com>; Jun Li <jun.li@....com>
> Cc: Francesco Dolcini <francesco@...cini.it>; devicetree@...r.kernel.org;
> festevam@...il.com; gregkh@...uxfoundation.org; kernel@...gutronix.de;
> linux-arm-kernel@...ts.infradead.org; dl-linux-imx <linux-imx@....com>;
> linux-kernel@...r.kernel.org; linux-usb@...r.kernel.org;
> peter.chen@....com; robh+dt@...nel.org; s.hauer@...gutronix.de;
> shawnguo@...nel.org; Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>;
> Francesco Dolcini <francesco.dolcini@...adex.com>
> Subject: Re: [PATCH v2 2/3] usb: chipidea: imx: support disabling runtime-pm
> 
> On Fri, May 05, 2023 at 12:06:18PM +0200, Luca Ceresoli wrote:
> > On Fri, 5 May 2023 09:49:16 +0000
> > Jun Li <jun.li@....com> wrote:
> > > Is your board design similar like Francesco's as below?
> >
> > Possibly, but I'm afraid I can't say: I am using the Toradex Colibri
> > i.MX6ULL SoM, whose schematics are not public.
> 
> I can confirm that it's the same.

Thanks Francesco for the confirmation, had a check with design team,
there is no status bit which can be used to judge the VDD_USB_CAP is
powered or not, so we have to add a board level dts property to tell
this usb phy driver to bypass MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS.

Before send a formal patch, I want to confirm this should work for your
HW design, like below simple hack:

diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
index e1a2b2ea098b..ec5ee790455e 100644
--- a/drivers/usb/phy/phy-mxs-usb.c
+++ b/drivers/usb/phy/phy-mxs-usb.c
@@ -178,7 +178,6 @@ static const struct mxs_phy_data imx6sx_phy_data = {
 };
 
 static const struct mxs_phy_data imx6ul_phy_data = {
-       .flags = MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS,
 };
 
 static const struct mxs_phy_data imx7ulp_phy_data = {

Thanks
Li Jun

> 
> Francesco