linux-kernel - Re: [PATCH v10 06/10] dt-bindings: serial: Document ma35d1 uart controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a62d278c-f47c-fa97-185e-b81ff4b28a4c@gmail.com>
Date:   Mon, 8 May 2023 15:01:01 +0800
From:   Jacky Huang <ychuang570808@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh@...nel.org>
Cc:     p.zabel@...gutronix.de, arnd@...db.de, jirislaby@...nel.org,
        schung@...oton.com, tmaimon77@...il.com,
        devicetree@...r.kernel.org, catalin.marinas@....com,
        gregkh@...uxfoundation.org, sboyd@...nel.org,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org, will@...nel.org,
        Jacky Huang <ychuang3@...oton.com>, lee@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, mturquette@...libre.com,
        mjchen@...oton.com, robh+dt@...nel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v10 06/10] dt-bindings: serial: Document ma35d1 uart
 controller



On 2023/5/8 下午 02:31, Krzysztof Kozlowski wrote:
> On 08/05/2023 05:26, Rob Herring wrote:
>> On Mon, 08 May 2023 02:59:32 +0000, Jacky Huang wrote:
>>> From: Jacky Huang <ychuang3@...oton.com>
>>>
>>> Add documentation that describes the nuvoton ma35d1 UART driver bindings.
>>>
>>> Signed-off-by: Jacky Huang <ychuang3@...oton.com>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> ---
>>>   .../serial/nuvoton,ma35d1-serial.yaml         | 48 +++++++++++++++++++
>>>   1 file changed, 48 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.yaml
>>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.example.dtb: camera-sensor@3c: port:endpoint:data-lanes: [[1]] is too short
>> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: port:endpoint:data-lanes: [[1]] is too short
>> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.example.dtb: pcie-ep@...00000: Unevaluated properties are not allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' were unexpected)
>> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
>> Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.example.dts:25:18: fatal error: dt-bindings/clock/nuvoton,ma35d1-clk.h: No such file or directory
>>     25 |         #include <dt-bindings/clock/nuvoton,ma35d1-clk.h>
>>        |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> compilation terminated.
>> make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.example.dtb] Error 1
> This however is related, although might be coming from earlier failure.
> I assume you run the check and you do not see any errors?
>
> Best regards,
> Krzysztof
>

Dear Krzysztof,

Thank you for your review.

Of course I have run the check.
I did not see any errors, because I have 
"dt-bindings/clock/nuvoton,ma35d1-clk.h".
This patch 6/10 depends on path 3/10 which include 
"dt-bindings/clock/nuvoton,ma35d1-clk.h".
Should I combine this patch 6/10 into patch 3/10?


Best Regards,
Jacky Huang