linux-kernel - Re: [PATCH v2 1/5] ASoC: tas2781: Add Header file for tas2781 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <68205138-a0ae-f6cf-c81b-e94168a01a29@linux.intel.com>
Date:   Mon, 8 May 2023 09:31:18 +0200
From:   Amadeusz Sławiński 
        <amadeuszx.slawinski@...ux.intel.com>
To:     Shenghao Ding <13916275206@....com>, broonie@...nel.org,
        devicetree@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org,
        robh+dt@...nel.org, lgirdwood@...il.com, perex@...ex.cz,
        pierre-louis.bossart@...ux.intel.com
Cc:     kevin-lu@...com, shenghao-ding@...com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, x1077012@...com, peeyush@...com,
        navada@...com, gentuser@...il.com, Ryan_Chu@...tron.com,
        Sam_Wu@...tron.com
Subject: Re: [PATCH v2 1/5] ASoC: tas2781: Add Header file for tas2781 driver

On 5/8/2023 7:44 AM, Shenghao Ding wrote:
> Create Header file for  tas2781 driver.
> 
> Signed-off-by: Shenghao Ding <13916275206@....com>
> 
> ---
> Changes in v2:
>   - fixed issue | Reported-by: kernel test robot <lkp@...el.com>
>     | Link: https://lore.kernel.org/oe-kbuild-all/202305022033.LiI7Ojm4-lkp@intel.com/
>   Changes to be committed:
> 	new file:   include/sound/tas2781-dsp.h
> 	new file:   include/sound/tas2781-tlv.h
> 	new file:   include/sound/tas2781.h
> ---

...

> +enum channel {
> +	top_left_Chn,
> +	top_right_chn,
> +	bottom_left_Chn,
> +	bottom_right_chn,
> +	max_chn,
> +};

Why some enums have capitalized Chn? Just use chn everywhere.