linux-kernel - Re: [PATCH] phy: mediatek: fix returning garbage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5cf30b2-c29c-03ac-e7fc-4c7da2cd0c5b@gmail.com>
Date:   Mon, 8 May 2023 10:24:19 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Tom Rix <trix@...hat.com>, chunkuang.hu@...nel.org,
        p.zabel@...gutronix.de, chunfeng.yun@...iatek.com,
        kishon@...nel.org, angelogioacchino.delregno@...labora.com,
        nathan@...nel.org, ndesaulniers@...gle.com, granquet@...libre.com,
        dri-devel@...ts.freedesktop.org,
        linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-phy@...ts.infradead.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] phy: mediatek: fix returning garbage



On 08/05/2023 09:48, Vinod Koul wrote:
> On 05-05-23, 17:37, Matthias Brugger wrote:
>>
>>
>> On 05/05/2023 11:28, Vinod Koul wrote:
>>> On 14-04-23, 08:22, Tom Rix wrote:
>>>> clang reports
>>>> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable
>>>>     'ret' is uninitialized when used here [-Werror,-Wuninitialized]
>>>>           if (ret)
>>>>               ^~~
>>>> ret should have been set by the preceding call to mtk_hdmi_pll_set_hw.
>>>
>>> I have applied "phy: mediatek: hdmi: mt8195: fix uninitialized variable
>>> usage in pll_calc"
>>
>> Thanks Vinod, that was on my list for today as well. I was a bit puzzled
>> because you took the patch that added it, but I wasn't sure if you would
>> take the fix. How do you want to handle things like this in the future?
> 
> Fixes should be sent as Fixes patch
> 

I'm not sure what do you mean. Patch subject includes the word fix and the patch 
has a fixes tag. What was missing here?

Does this mean you will take fixes for this driver in the future or do you want 
me to take care of them?

Regards,
Matthias