linux-kernel - Re: [RFC PATCH] workqueue: fix cast warnings on i386

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <eabf596d-8e19-484d-87b6-11222a5832eb@app.fastmail.com>
Date:   Mon, 08 May 2023 15:41:15 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Randy Dunlap" <rdunlap@...radead.org>,
        "Lai Jiangshan" <jiangshanlai@...il.com>
Cc:     linux-kernel@...r.kernel.org, "Tejun Heo" <tj@...nel.org>
Subject: Re: [RFC PATCH] workqueue: fix cast warnings on i386

On Mon, May 1, 2023, at 06:42, Randy Dunlap wrote:
> On 4/30/23 21:37, Lai Jiangshan wrote:
>> Both the type of the "data" and WORK_STRUCT_WQ_DATA_MASK are
>> "unsigned long", so I don't think "(data & WORK_STRUCT_WQ_DATA_MASK)"
>> needs to be converted to "unsigned long".
>> 
>>         WORK_STRUCT_FLAG_MASK   = (1UL << WORK_STRUCT_FLAG_BITS) - 1,
>>         WORK_STRUCT_WQ_DATA_MASK = ~WORK_STRUCT_FLAG_MASK,
>> 
>> This simple fix might hide the real problem.
>
> Thanks for replying.
>
> Do you have any suggestions for how to eliminate these warnings on i386
> and ARCH=um SUBARCH=i386?

I'm pretty sure the patch I posted earlier is the correct one, see
https://lore.kernel.org/all/20230117164041.1207412-1-arnd@kernel.org/

Sorry I never followed up on this after the initial post, I have
a backlog of patches that I sent out as build fixes but that for
some reason have not made it in.

     Arnd