linux-kernel - Re: [RFC PATCH] workqueue: fix cast warnings on i386

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c1124dc-c4fd-62d1-f1ea-b0a3d0b36fbb@infradead.org>
Date:   Mon, 8 May 2023 12:06:26 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Arnd Bergmann <arnd@...db.de>,
        Lai Jiangshan <jiangshanlai@...il.com>
Cc:     linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>
Subject: Re: [RFC PATCH] workqueue: fix cast warnings on i386



On 5/8/23 06:41, Arnd Bergmann wrote:
> On Mon, May 1, 2023, at 06:42, Randy Dunlap wrote:
>> On 4/30/23 21:37, Lai Jiangshan wrote:
>>> Both the type of the "data" and WORK_STRUCT_WQ_DATA_MASK are
>>> "unsigned long", so I don't think "(data & WORK_STRUCT_WQ_DATA_MASK)"
>>> needs to be converted to "unsigned long".
>>>
>>>         WORK_STRUCT_FLAG_MASK   = (1UL << WORK_STRUCT_FLAG_BITS) - 1,
>>>         WORK_STRUCT_WQ_DATA_MASK = ~WORK_STRUCT_FLAG_MASK,
>>>
>>> This simple fix might hide the real problem.
>>
>> Thanks for replying.
>>
>> Do you have any suggestions for how to eliminate these warnings on i386
>> and ARCH=um SUBARCH=i386?
> 
> I'm pretty sure the patch I posted earlier is the correct one, see
> https://lore.kernel.org/all/20230117164041.1207412-1-arnd@kernel.org/
> 

Thanks for the reply. Your patch looks good. I appreciate the
explanation.

> Sorry I never followed up on this after the initial post, I have
> a backlog of patches that I sent out as build fixes but that for
> some reason have not made it in.

I know how that goes. I have quite a few as well.

-- 
~Randy