linux-kernel - Re: [PATCH v1 3/7] iio: light: vcnl4000: Add als

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 May 2023 23:08:41 +0800
From:   kernel test robot <lkp@...el.com>
To:     Astrid Rost <astrid.rost@...s.com>,
        Jonathan Cameron <jic23@...nel.org>
Cc:     oe-kbuild-all@...ts.linux.dev, kernel@...s.com,
        Astrid Rost <astridr@...s.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/7] iio: light: vcnl4000: Add als_it for vcnl4040/4200

Hi Astrid,

kernel test robot noticed the following build errors:

[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on linus/master v6.4-rc1 next-20230508]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Astrid-Rost/iio-light-vcnl4000-Add-proximity-ps_it-for-vcnl4200/20230508-161005
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/20230508070925.2123265-4-astrid.rost%40axis.com
patch subject: [PATCH v1 3/7] iio: light: vcnl4000: Add als_it for vcnl4040/4200
config: i386-randconfig-a016-20230508 (https://download.01.org/0day-ci/archive/20230508/202305082245.Fy28zlcu-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/6ff2e1cf084f5b3038f2d72110fb01f2a8353a34
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Astrid-Rost/iio-light-vcnl4000-Add-proximity-ps_it-for-vcnl4200/20230508-161005
        git checkout 6ff2e1cf084f5b3038f2d72110fb01f2a8353a34
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 olddefconfig
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305082245.Fy28zlcu-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: drivers/iio/light/vcnl4000.o: in function `vcnl4040_write_als_it':
>> drivers/iio/light/vcnl4000.c:580: undefined reference to `__divdi3'


vim +580 drivers/iio/light/vcnl4000.c

   552	
   553	static ssize_t vcnl4040_write_als_it(struct vcnl4000_data *data, int val)
   554	{
   555		unsigned int i;
   556		int ret, index = -1;
   557		u16 regval;
   558		const int(*als_it_times)[][2];
   559		int size;
   560	
   561		if (data->id == VCNL4200) {
   562			als_it_times = &vcnl4200_als_it_times;
   563			size = ARRAY_SIZE(vcnl4200_als_it_times);
   564		} else {
   565			als_it_times = &vcnl4040_als_it_times;
   566			size = ARRAY_SIZE(vcnl4040_als_it_times);
   567		}
   568	
   569		for (i = 0; i < size; i++) {
   570			if (val == (*als_it_times)[i][1]) {
   571				index = i;
   572				break;
   573			}
   574		}
   575	
   576		if (index < 0)
   577			return -EINVAL;
   578	
   579		data->vcnl4200_al.sampling_rate = ktime_set(0, val * 1200000);
 > 580		data->al_scale = 12000000000 / val;
   581	
   582		mutex_lock(&data->vcnl4000_lock);
   583	
   584		ret = i2c_smbus_read_word_data(data->client, VCNL4200_AL_CONF);
   585		if (ret < 0)
   586			goto out;
   587	
   588		regval = (ret & ~VCNL4040_ALS_CONF_IT) |
   589		    FIELD_PREP(VCNL4040_ALS_CONF_IT, index);
   590		ret = i2c_smbus_write_word_data(data->client, VCNL4200_AL_CONF,
   591						regval);
   592	
   593	out:
   594		mutex_unlock(&data->vcnl4000_lock);
   595		return ret;
   596	}
   597	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests