linux-kernel - Re: [PATCH v3 0/6] pci-hyper: Fix race condition bugs for fast device hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZFkovIxZudoLISBv@liuwe-devbox-debian-v2>
Date:   Mon, 8 May 2023 16:52:12 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Dexuan Cui <decui@...rosoft.com>
Cc:     "'bhelgaas@...gle.com'" <bhelgaas@...gle.com>,
        "'davem@...emloft.net'" <davem@...emloft.net>,
        "'edumazet@...gle.com'" <edumazet@...gle.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Jake Oshins <jakeo@...rosoft.com>,
        "'kuba@...nel.org'" <kuba@...nel.org>,
        "'kw@...ux.com'" <kw@...ux.com>, KY Srinivasan <kys@...rosoft.com>,
        "'leon@...nel.org'" <leon@...nel.org>,
        "'linux-pci@...r.kernel.org'" <linux-pci@...r.kernel.org>,
        "'lpieralisi@...nel.org'" <lpieralisi@...nel.org>,
        "Michael Kelley (LINUX)" <mikelley@...rosoft.com>,
        "'pabeni@...hat.com'" <pabeni@...hat.com>,
        "'robh@...nel.org'" <robh@...nel.org>,
        "'saeedm@...dia.com'" <saeedm@...dia.com>,
        "'wei.liu@...nel.org'" <wei.liu@...nel.org>,
        Long Li <longli@...rosoft.com>,
        "'boqun.feng@...il.com'" <boqun.feng@...il.com>,
        Saurabh Singh Sengar <ssengar@...rosoft.com>,
        "'helgaas@...nel.org'" <helgaas@...nel.org>,
        "'linux-hyperv@...r.kernel.org'" <linux-hyperv@...r.kernel.org>,
        "'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
        "'linux-rdma@...r.kernel.org'" <linux-rdma@...r.kernel.org>,
        "'netdev@...r.kernel.org'" <netdev@...r.kernel.org>,
        Jose Teuttli Carranco <josete@...rosoft.com>
Subject: Re: [PATCH v3 0/6] pci-hyper: Fix race condition bugs for fast
 device hotplug

On Fri, Apr 21, 2023 at 10:23:03PM +0000, Dexuan Cui wrote:
> > From: Dexuan Cui
> > Sent: Thursday, April 20, 2023 7:04 PM
> > > ...
> > >
> > > Dexuan Cui (6):
> > >   PCI: hv: Fix a race condition bug in hv_pci_query_relations()
> > >   PCI: hv: Fix a race condition in hv_irq_unmask() that can cause panic
> > >   PCI: hv: Remove the useless hv_pcichild_state from struct hv_pci_dev
> > >   Revert "PCI: hv: Fix a timing issue which causes kdump to fail
> > >     occasionally"
> > >   PCI: hv: Add a per-bus mutex state_lock
> > >   PCI: hv: Use async probing to reduce boot time
> > >
> > >  drivers/pci/controller/pci-hyperv.c | 145 +++++++++++++++++-----------
> > >  1 file changed, 86 insertions(+), 59 deletions(-)
> > 
> > Hi Bjorn, Lorenzo, since basically this patchset is Hyper-V stuff, I would
> > like it to go through the hyper-v tree if you have no objection.
> > 
> > The hyper-v tree already has one big PCI patch from Michael:
> > https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git/commit/?h=
> > hyperv-next&id=2c6ba4216844ca7918289b49ed5f3f7138ee2402
> > 
> > Thanks,
> > Dexuan
> 
> Hi Lorenzo, thanks for Ack'ing the patch:
>   Re: [PATCH v2] PCI: hv: Replace retarget_msi_interrupt_params with hyperv_pcpu_input_arg
> 
> It would be great if you and/or Bjorn can Ack this patchset as well :-)
> 

Lorenzo and Bjorn, are you happy with these patches? I can collect them
via the hyperv-fixes tree.

Thanks,
Wei.

> v1 of this patchset was posted on 3/28:
> https://lwn.net/ml/linux-kernel/20230328045122.25850-1-decui%40microsoft.com/
> and v3 got Michael Kelley's and Long Li's Reviewed-by.
> 
> I have done a long-haul testing against the patchset and it worked
> reliably without causing any issue: without the patchset, usually the VM
> can crash within 1~2 days; with the patchset, the VM is still running fine 
> after 2 weeks.
> 
> Thanks,
> Dexuan