linux-kernel - Re: [PATCH v4 01/15] dmaengine: idxd: add wq driver name support for accel-config user tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9bad7c2-14d7-7f06-da50-81069853babd@intel.com>
Date:   Tue, 9 May 2023 10:48:57 -0700
From:   Fenghua Yu <fenghua.yu@...el.com>
To:     Tom Zanussi <tom.zanussi@...ux.intel.com>,
        <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <vkoul@...nel.org>
CC:     <dave.jiang@...el.com>, <tony.luck@...el.com>,
        <wajdi.k.feghali@...el.com>, <james.guilford@...el.com>,
        <kanchana.p.sridhar@...el.com>, <giovanni.cabiddu@...el.com>,
        <linux-kernel@...r.kernel.org>, <linux-crypto@...r.kernel.org>,
        <dmaengine@...r.kernel.org>
Subject: Re: [PATCH v4 01/15] dmaengine: idxd: add wq driver name support for
 accel-config user tool

Hi, Tom,

On 5/8/23 13:07, Tom Zanussi wrote:
> From: Dave Jiang <dave.jiang@...el.com>
> 
> With the possibility of multiple wq drivers that can be bound to the wq,
> the user config tool accel-config needs a way to know which wq driver to
> bind to the wq. Introduce per wq driver_name sysfs attribute where the user
> can indicate the driver to be bound to the wq. This allows accel-config to
> just bind to the driver using wq->driver_name.
> 
> Signed-off-by: Dave Jiang <dave.jiang@...el.com>
> Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>
> ---
>   .../ABI/stable/sysfs-driver-dma-idxd          |  6 ++++
>   drivers/dma/idxd/cdev.c                       |  8 ++++++
>   drivers/dma/idxd/dma.c                        |  6 ++++
>   drivers/dma/idxd/idxd.h                       |  9 ++++++
>   drivers/dma/idxd/sysfs.c                      | 28 +++++++++++++++++++
>   include/uapi/linux/idxd.h                     |  1 +
>   6 files changed, 58 insertions(+)
> 
> diff --git a/Documentation/ABI/stable/sysfs-driver-dma-idxd b/Documentation/ABI/stable/sysfs-driver-dma-idxd
> index 3becc9a82bdf..d5daae442fe7 100644
> --- a/Documentation/ABI/stable/sysfs-driver-dma-idxd
> +++ b/Documentation/ABI/stable/sysfs-driver-dma-idxd
> @@ -244,6 +244,12 @@ Description:	Shows the operation capability bits displayed in bitmap format
>   		correlates to the operations allowed. It's visible only
>   		on platforms that support the capability.
>   
> +What:		/sys/bus/dsa/devices/wq<m>.<n>/driver_name
> +Date:		Mar 27, 2023 > +KernelVersion:	6.4.0

Need to be changed to 6.5.0 now:)

After fixing the KernelVersion,

Reviewed-by: Fenghua Yu <fenghua.yu@...el.com>

Thanks.

-Fenghua