[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230508190035.24b5710e@kernel.org>
Date: Mon, 8 May 2023 19:00:35 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Siddharth Vadapalli <s-vadapalli@...com>
Cc: <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>,
<davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>, <srk@...com>
Subject: Re: [PATCH net] net: phy: dp83867: add w/a for packet errors seen
with short cables
Thanks for the patch! Some nit picks below..
On Mon, 8 May 2023 12:30:19 +0530 Siddharth Vadapalli wrote:
> + err = phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_DSP_FFE_CFG, 0X0E81);
Pleas wrap this line at 80 characters, there's no reason for it
to be this long.
And 0x prefix should not be in upper case, here and in the new define
you're adding.
--
pw-bot: cr
Powered by blists - more mailing lists