linux-kernel - Re: [PATCH] iommu: Add Kconfig help text for IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0a570c3-4145-8413-cb7a-e4313819ae1b@linux.intel.com>
Date:   Tue, 9 May 2023 09:55:34 +0800
From:   Baolu Lu <baolu.lu@...ux.intel.com>
To:     Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     baolu.lu@...ux.intel.com, Jason Gunthorpe <jgg@...dia.com>,
        LKML <linux-kernel@...r.kernel.org>, iommu@...ts.linux.dev,
        Joerg Roedel <joro@...tes.org>,
        Jean-Philippe Brucker <jean-philippe@...aro.com>,
        Robin Murphy <robin.murphy@....com>,
        Will Deacon <will@...nel.org>, Raj Ashok <ashok.raj@...el.com>,
        "Tian, Kevin" <kevin.tian@...el.com>, Yi Liu <yi.l.liu@...el.com>,
        "Yu, Fenghua" <fenghua.yu@...el.com>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        Jean-Philippe Brucker <jean-philippe.brucker@....com>
Subject: Re: [PATCH] iommu: Add Kconfig help text for IOMMU_SVA

On 5/9/23 4:21 AM, Jacob Pan wrote:
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index db98c3f86e8c..7106f3af74ee 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -153,9 +153,13 @@ config IOMMU_DMA
>   	select IRQ_MSI_IOMMU
>   	select NEED_SG_DMA_LENGTH
>   
> +config IOMMU_MM_PASID
> +	bool
> +
>   # Shared Virtual Addressing
>   config IOMMU_SVA
>   	bool
> +	select IOMMU_MM_PASID
>   
>   config FSL_PAMU
>   	bool "Freescale IOMMU support"
> diff --git a/drivers/iommu/intel/Kconfig b/drivers/iommu/intel/Kconfig
> index 2e56bd79f589..b4d7bd68a911 100644
> --- a/drivers/iommu/intel/Kconfig
> +++ b/drivers/iommu/intel/Kconfig
> @@ -50,6 +50,7 @@ config INTEL_IOMMU_SVM
>   	depends on X86_64
>   	select MMU_NOTIFIER
>   	select IOMMU_SVA
> +	select IOMMU_MM_PASID

IOMMU_SVA has already selected IOMMU_MM_PASID, so there's no need to
select it again here?

IOMMU_SVA selects IOMMU_MM_PASID, the vt-d driver itself has no need to
know about this.

>   	help
>   	  Shared Virtual Memory (SVM) provides a facility for devices
>   	  to access DMA resources through process address space by

Best regards,
baolu