linux-kernel - Re: [PATCH] parisc: kexec: include reboot.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 May 2023 14:08:31 +0200
From:   Helge Deller <deller@....de>
To:     Simon Horman <horms@...nel.org>, Baoquan He <bhe@...hat.com>
Cc:     "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
        "Leizhen (ThunderTown)" <thunder.leizhen@...wei.com>,
        kexec@...ts.infradead.org, linux-parisc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc: kexec: include reboot.h

On 5/9/23 13:52, Simon Horman wrote:
> On Tue, May 09, 2023 at 05:01:42PM +0800, Baoquan He wrote:
>> On 05/09/23 at 09:01am, Simon Horman wrote:
>>> Include reboot.h in machine_kexec.c for declaration of
>>> machine_crash_shutdown and machine_shutdown.
>>>
>>> gcc-12 with W=1 reports:
>>>
>>>   arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes]
>>>      57 | void machine_crash_shutdown(struct pt_regs *regs)
>>>         |      ^~~~~~~~~~~~~~~~~~~~~~
>>>   arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes]
>>>      61 | void machine_shutdown(void)
>>>         |      ^~~~~~~~~~~~~~~~
>>>
>>> No functional changes intended.
>>> Compile tested only.
>>>
>>> Signed-off-by: Simon Horman <horms@...nel.org>
>>
>> Acked-by: Baoquan He <bhe@...hat.com>

applied to parisc for-next git tree.

Thanks!
Helge