linux-kernel - Re: [PATCH] parisc: kexec: include reboot.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 May 2023 12:11:47 +0800
From:   Baoquan He <bhe@...hat.com>
To:     Simon Horman <horms@...nel.org>
Cc:     "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
        Helge Deller <deller@....de>,
        "Leizhen (ThunderTown)" <thunder.leizhen@...wei.com>,
        kexec@...ts.infradead.org, linux-parisc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc: kexec: include reboot.h

On 05/09/23 at 01:52pm, Simon Horman wrote:
> On Tue, May 09, 2023 at 05:01:42PM +0800, Baoquan He wrote:
> > On 05/09/23 at 09:01am, Simon Horman wrote:
> > > Include reboot.h in machine_kexec.c for declaration of
> > > machine_crash_shutdown and machine_shutdown.
> > > 
> > > gcc-12 with W=1 reports:
> > > 
> > >  arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes]
> > >     57 | void machine_crash_shutdown(struct pt_regs *regs)
> > >        |      ^~~~~~~~~~~~~~~~~~~~~~
> > >  arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes]
> > >     61 | void machine_shutdown(void)
> > >        |      ^~~~~~~~~~~~~~~~
> > > 
> > > No functional changes intended.
> > > Compile tested only.
> > > 
> > > Signed-off-by: Simon Horman <horms@...nel.org>
> > 
> > Acked-by: Baoquan He <bhe@...hat.com>
> > 
> > We may need to find out the places in all architectures and fix all of
> > them.
> 
> I did check. It seemed to be needed for riscv, m68k and parisc.
> I've sent out patches for all three. But I may have missed something.

That's great, thanks. I didn't notice the other two.