linux-kernel - Re: [PATCH v9.1 01/11] fprobe: Pass return address to the handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230509235121.28974ab2b5341eade5491a35@kernel.org>
Date:   Tue, 9 May 2023 23:51:21 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Florent Revest <revest@...omium.org>,
        Mark Rutland <mark.rutland@....com>,
        Will Deacon <will@...nel.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Martin KaFai Lau <martin.lau@...ux.dev>, bpf@...r.kernel.org
Subject: Re: [PATCH v9.1 01/11] fprobe: Pass return address to the handlers

On Fri, 5 May 2023 11:21:34 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Tue,  2 May 2023 11:17:28 +0900
> "Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:
> 
> > From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> > 
> > Pass return address as 'ret_ip' to the fprobe entry and return handlers.
> 
> The change log tells us "what" but not "why".

Indeed, and thanks, I almost forgot the reason why I introduced it :(
This is actually for fprobe_exit_handler() to pass the return address to
user handler so that the fprobe-events can show the return address correctly.
When I implemented the fprobe-events, I found this was required but splitted
from the main fprobe event patch but forgot to update the description.

Let me update it.

Thank you!

> 
> -- Steve
> 
> > 
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> > ---
> >


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>