linux-kernel - Re: [PATCH v9.1 11/11] Documentation: tracing/probes: Add fprobe event tracing document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230509235832.3499572829aa62b414082693@kernel.org>
Date:   Tue, 9 May 2023 23:58:32 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Florent Revest <revest@...omium.org>,
        Mark Rutland <mark.rutland@....com>,
        Will Deacon <will@...nel.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Martin KaFai Lau <martin.lau@...ux.dev>, bpf@...r.kernel.org
Subject: Re: [PATCH v9.1 11/11] Documentation: tracing/probes: Add fprobe
 event tracing document

On Fri, 5 May 2023 11:20:26 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Tue,  2 May 2023 11:18:56 +0900
> "Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:
> 
> > + # cat events/fprobes/myprobe/format
> > + name: myprobe
> > + ID: 1313
> > + format:
> > + 	field:unsigned short common_type;	offset:0;	size:2;	signed:0;
> > + 	field:unsigned char common_flags;	offset:2;	size:1;	signed:0;
> > + 	field:unsigned char common_preempt_count;	offset:3;	size:1;	signed:0;
> > + 	field:int common_pid;	offset:4;	size:4;	signed:1;
> > +
> > + 	field:unsigned long __probe_ip;	offset:8;	size:8;	signed:0;
> > + 	field:u64 count;	offset:16;	size:8;	signed:0;
> > + 	field:u64 pos;	offset:24;	size:8;	signed:0;
> 
> git complained when I pulled this in because there above lines is:
> 
> <space><tab>field...
> 
> Where, the space should be removed.

Ah, OK. I just added a head space for each line... (hmm, checkpatch.pl may not check it?)

I'll fix it.

Thank you!

> 
> -- Steve
> 
> > +
> > + print fmt: "(%lx) count=%Lu pos=0x%Lx", REC->__probe_ip, REC->count, REC->pos


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>