linux-kernel - Re: [PATCH v3 2/7] ufs: core: Update the ufshcd_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 May 2023 14:25:05 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     "Bao D. Nguyen" <quic_nguyenb@...cinc.com>,
        quic_asutoshd@...cinc.com, quic_cang@...cinc.com, mani@...nel.org,
        stanley.chu@...iatek.com, adrian.hunter@...el.com,
        beanhuo@...ron.com, avri.altman@....com, martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/7] ufs: core: Update the ufshcd_clear_cmds()
 functionality

On 5/9/23 22:24, Bao D. Nguyen wrote:
> -		dev_err(hba->dev, "%s: failed to clear requests %#lx\n",
> -			__func__, not_cleared);
> +			dev_err(hba->dev, "%s: failed to clear requests %#lx\n",
> +				__func__, not_cleared);
> +		}

Please change "requests" into "request" and "not_cleared" into "pos". 
Otherwise this patch looks good to me. Hence:

Reviewed-by: Bart Van Assche <bvanassche@....org>