linux-kernel - Re: [PATCH] ASoC: dt-bindings: Adjust #sound-dai-cells on TI's single-DAI codecs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <A8647EF5-566A-4B99-9020-772810CB2BF7@cutebit.org>
Date:   Wed, 10 May 2023 09:30:12 +0200
From:   Martin Povišer <povik+lin@...ebit.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, Andrew Davis <afd@...com>,
        Shi Fu <shifu0704@...ndersoft.com>,
        Shenghao Ding <shenghao-ding@...com>, kevin-lu@...com,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, asahi@...ts.linux.dev
Subject: Re: [PATCH] ASoC: dt-bindings: Adjust #sound-dai-cells on TI's
 single-DAI codecs


> On 10. 5. 2023, at 9:17, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> 
> On 09/05/2023 17:34, Martin Povišer wrote:
>> A bunch of TI's codecs have binding schemas which force #sound-dai-cells
>> to one despite those codecs only having a single DAI. Allow for bindings
>> with zero DAI cells and deprecate the former non-zero value.
>> 
>> Signed-off-by: Martin Povišer <povik+lin@...ebit.org>
>> ---
>> Documentation/devicetree/bindings/sound/tas2562.yaml | 6 ++++--
>> Documentation/devicetree/bindings/sound/tas2770.yaml | 6 ++++--
>> Documentation/devicetree/bindings/sound/tas27xx.yaml | 6 ++++--
>> 3 files changed, 12 insertions(+), 6 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/sound/tas2562.yaml b/Documentation/devicetree/bindings/sound/tas2562.yaml
>> index a5bb561bfcfb..31a3024ea789 100644
>> --- a/Documentation/devicetree/bindings/sound/tas2562.yaml
>> +++ b/Documentation/devicetree/bindings/sound/tas2562.yaml
>> @@ -55,7 +55,9 @@ properties:
>>     description: TDM TX current sense time slot.
>> 
>>   '#sound-dai-cells':
>> -    const: 1
>> +    # The codec has a single DAI, the #sound-dai-cells=<1>; case is left in for backward
>> +    # compatibility but is deprecated.
>> +    enum: [0, 1]
> 
> Does it? I see playback and capture.

I think so. Playback and capture are not separate DAIs.

Martin

> 
> Best regards,
> Krzysztof