linux-kernel - Re: [PATCH] ASoC: dt-bindings: Adjust #sound-dai-cells on TI's single-DAI codecs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f40daf65-ac65-5df6-828b-c5ded00c4c8a@linaro.org>
Date:   Wed, 10 May 2023 09:42:49 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Martin Povišer <povik+lin@...ebit.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, Andrew Davis <afd@...com>,
        Shi Fu <shifu0704@...ndersoft.com>,
        Shenghao Ding <shenghao-ding@...com>, kevin-lu@...com,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, asahi@...ts.linux.dev
Subject: Re: [PATCH] ASoC: dt-bindings: Adjust #sound-dai-cells on TI's
 single-DAI codecs

On 10/05/2023 09:33, Martin Povišer wrote:
> 
>> On 10. 5. 2023, at 9:30, Martin Povišer <povik+lin@...ebit.org> wrote:
>>
>>> On 10. 5. 2023, at 9:17, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
>>>
>>> On 09/05/2023 17:34, Martin Povišer wrote:
>>>> A bunch of TI's codecs have binding schemas which force #sound-dai-cells
>>>> to one despite those codecs only having a single DAI. Allow for bindings
>>>> with zero DAI cells and deprecate the former non-zero value.
>>>>
>>>> Signed-off-by: Martin Povišer <povik+lin@...ebit.org>
>>>> ---
> 
>>>>  '#sound-dai-cells':
>>>> -    const: 1
>>>> +    # The codec has a single DAI, the #sound-dai-cells=<1>; case is left in for backward
>>>> +    # compatibility but is deprecated.
>>>> +    enum: [0, 1]
>>>
>>> Does it? I see playback and capture.
>>
>> I think so. Playback and capture are not separate DAIs.
>>
>> Martin
> 
> I double checked, I am pretty sure. There’s a single snd_soc_dai_driver,
> which becomes a single DAI.

Indeed, I see now one entry... Ehh... -ENOTENOUGHCOFFEE

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof