linux-kernel - [REGRESSION] wifi: brcmfmac: add firmware vendor info in driver info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 May 2023 10:25:12 +0200
From:   Felix <nimrod4garoa@...il.com>
To:     Arend van Spriel <aspriel@...il.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>
Cc:     regressions@...ts.linux.dev,
        Arend van Spriel <arend.vanspriel@...adcom.com>,
        Kalle Valo <kvalo@...nel.org>, linux-kernel@...r.kernel.org,
        linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        SHA-cyfmac-dev-list@...ineon.com
Subject: [REGRESSION] wifi: brcmfmac: add firmware vendor info in driver info

Changes made by the mentioned commit lead to Oops when waking up after
suspend to RAM.

When waking up a Dell XPS 13 9350 with BCM4350 wifi card after suspend
to RAM, the kernel hangs with a NULL pointer dereference and Oops. The
issues was introduced by commit
da6d9c8ecd00e20218461007948f2b0a8e7fa242 and only happens when the
brcmfmac module is loaded. This issue is the reason we could not
upgrade to newer kernels than the 6.1 series on the affected machine.

Details:

On a Dell XPS 13 9350 laptop with Broadcom BCM4350 wifi card (according
to lspci), every kernel starting with 6.2 hangs when waking up after
suspend to RAM. The issue persisted as of May 2nd (last tested commit
was 348551ddaf311c76b01cdcbaf61b6fef06a49144). Passing the debug and
no_console_suspend parameters to the kernel show that a NULL pointer
dereference and an Oops happen at wakeup. Please find the kernel
messages readable on the screen at this point attached
(kernel_log_after_suspend.txt).

A bisection was successful and produced the first bad commit
[da6d9c8ecd00e20218461007948f2b0a8e7fa242] wifi: brcmfmac: add firmware
vendor info in driver info
I've attached the bisection log as well (bisect.txt).

Suspend to RAM works on this machine on newer kernels once the brcmfmac
module is unloaded.

Distribution: Arch Linux
Architecture: x86_64
Device: Dell XPS 13 9350 with BCM4350 wifi card
Kernel config used at compilation (created using the Arch Linux default
config and make olddefconfig):
https://gist.githubusercontent.com/maclomhair/e33fa7eece8f8c77e5a88c4eede2f523/raw/429dfb022498c026225865dbb3ab2f75d5030a54/config
Dmesg output after boot:
https://gist.githubusercontent.com/maclomhair/47c75fa759d93800e7fb5e937fabef3e/raw/10750996a1ea9dcb3fa14d9b94e11fedd3abf280/dmesg

#regzbot introduced da6d9c8ecd00e20218461007948f2b0a8e7fa242

Thank you for your time,
Felix

View attachment "kernel_log_after_suspend.txt" of type "text/plain" (3278 bytes)

View attachment "bisect.log" of type "text/x-log" (2740 bytes)