linux-kernel - Re: [PATCH] accel/qaic: silence some uninitialized variable warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d1fb58f-f98b-ba17-65e9-9ea4b467102a@quicinc.com>
Date:   Wed, 10 May 2023 08:57:03 -0600
From:   Jeffrey Hugo <quic_jhugo@...cinc.com>
To:     Dan Carpenter <dan.carpenter@...aro.org>
CC:     Oded Gabbay <ogabbay@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] accel/qaic: silence some uninitialized variable warnings

On 5/3/2023 4:41 AM, Dan Carpenter wrote:
> Smatch complains that these are not initialized if get_cntl_version()
> fails but we still print them in the debug message.  Not the end of
> the world, but true enough.  Let's just initialize them to a dummy value
> to make the checker happy.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Thanks for the cleanup.

Reviewed-by: Jeffrey Hugo <quic_jhugo@...cinc.com>

Could use a fixes tag, and also I'd prefer to maintain the style of 
sorting the variable declaration lines by line length.  Given the minor 
nature of these nits, I plan to address them.