linux-kernel - Re: [PATCH 2/2] Input: cap11xx - add advanced sensitivity settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZF2A/STY66sqoOLX@google.com>
Date:   Thu, 11 May 2023 16:57:49 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Jiri Valek - 2N <jiriv@...s.com>
Cc:     krzysztof.kozlowski+dt@...aro.org, devicetree@...r.kernel.org,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        robh+dt@...nel.org, u.kleine-koenig@...gutronix.de
Subject: Re: [PATCH 2/2] Input: cap11xx - add advanced sensitivity settings

Hi Jiri,

On Sat, Apr 15, 2023 at 01:38:15AM +0200, Jiri Valek - 2N wrote:
> @@ -474,7 +645,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
>  	if (error)
>  		return error;
>  
> -	irq = irq_of_parse_and_map(node, 0);
> +	irq = irq_of_parse_and_map(dev->of_node, 0);

Do you know if this is actually needed or we can rely on I2C core to
figure out the interrupt for us?

Also, could I ask you to move the driver from of_property_*() to
device_property_*() API?

Thanks.

-- 
Dmitry