linux-kernel - Re: [PATCH 2/2] Input: cap11xx - add advanced sensitivity settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <99582640-7486-7771-9fd0-c417e283051e@axis.com>
Date:   Tue, 13 Jun 2023 15:35:39 +0200
From:   Jiri Valek - 2N <jiriv@...s.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:     <krzysztof.kozlowski+dt@...aro.org>, <devicetree@...r.kernel.org>,
        <linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <robh+dt@...nel.org>, <u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH 2/2] Input: cap11xx - add advanced sensitivity settings

Hi Dmitry,

On 5/12/23 01:57, Dmitry Torokhov wrote:
> Hi Jiri,
> 
> On Sat, Apr 15, 2023 at 01:38:15AM +0200, Jiri Valek - 2N wrote:
>> @@ -474,7 +645,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
>>  	if (error)
>>  		return error;
>>  
>> -	irq = irq_of_parse_and_map(node, 0);
>> +	irq = irq_of_parse_and_map(dev->of_node, 0);
> 
> Do you know if this is actually needed or we can rely on I2C core to
> figure out the interrupt for us?

Agree and verified that's really not needed. I2C core do the job.
I will remove it.

> 
> Also, could I ask you to move the driver from of_property_*() to
> device_property_*() API?

And yes. I can move it to device_property API.

I prepare the changes as separate commits after I solve issues
with my "add advanced sensitivity settings" patch.

> 
> Thanks.
> 

BR,
Jiri Valek