linux-kernel - Re: [PATCH] accel/qaic: silence some uninitialized variable warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a144e830-acf8-55c6-c323-d049095e9fac@quicinc.com>
Date:   Thu, 11 May 2023 08:34:34 -0700
From:   Carl Vanderlip <quic_carlv@...cinc.com>
To:     Dan Carpenter <dan.carpenter@...aro.org>,
        Jeffrey Hugo <quic_jhugo@...cinc.com>
CC:     Oded Gabbay <ogabbay@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] accel/qaic: silence some uninitialized variable warnings

On 5/3/2023 3:41 AM, Dan Carpenter wrote:
> Smatch complains that these are not initialized if get_cntl_version()
> fails but we still print them in the debug message.  Not the end of
> the world, but true enough.  Let's just initialize them to a dummy value
> to make the checker happy.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

LGTM

Reviewed-by: Carl Vanderlip <quic_carlv@...cinc.com>