linux-kernel - Re: [PATCH v2] w1: Replace usage of found with dedicated list iterator variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c626e464-64e2-3cdb-7cf3-c76770feb1f0@linaro.org>
Date:   Fri, 12 May 2023 09:27:33 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Jakob Koschel <jkl820.git@...il.com>,
        Evgeniy Polyakov <zbr@...emap.net>,
        Krzysztof Kozlowski <krzk@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] w1: Replace usage of found with dedicated list
 iterator variable

On 10/05/2023 00:49, Jakob Koschel wrote:
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
> 
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
> 
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
> 
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1]
> Signed-off-by: Jakob Koschel <jkl820.git@...il.com>
> ---
> Changes in v2:
>   - fix checkpatch intentation issues

I don't see the differences and checkpatch still complains. Are you sure
you sent v2?

Best regards,
Krzysztof