linux-kernel - Re: [PATCH 1/3] perf annotate: Handle more instructions on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fVkLpcyuEjay_VUq9+K7nFRKPTCYr6SH-VBcrSfkKUoYQ@mail.gmail.com>
Date:   Mon, 15 May 2023 10:08:31 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-perf-users@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 1/3] perf annotate: Handle more instructions on x86

On Wed, May 10, 2023 at 11:27 PM Namhyung Kim <namhyung@...nel.org> wrote:
>
> I found some instructions didn't parse the operands properly.
> Add them to the table to fix the issue.
>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

Acked-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/arch/x86/annotate/instructions.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/tools/perf/arch/x86/annotate/instructions.c b/tools/perf/arch/x86/annotate/instructions.c
> index 305872692bfd..5c7bec25fee4 100644
> --- a/tools/perf/arch/x86/annotate/instructions.c
> +++ b/tools/perf/arch/x86/annotate/instructions.c
> @@ -35,12 +35,14 @@ static struct ins x86__instructions[] = {
>         { .name = "cs",         .ops = &mov_ops,  },
>         { .name = "dec",        .ops = &dec_ops,  },
>         { .name = "decl",       .ops = &dec_ops,  },
> +       { .name = "decq",       .ops = &dec_ops,  },
>         { .name = "divsd",      .ops = &mov_ops,  },
>         { .name = "divss",      .ops = &mov_ops,  },
>         { .name = "gs",         .ops = &mov_ops,  },
>         { .name = "imul",       .ops = &mov_ops,  },
>         { .name = "inc",        .ops = &dec_ops,  },
>         { .name = "incl",       .ops = &dec_ops,  },
> +       { .name = "incq",       .ops = &dec_ops,  },
>         { .name = "ja",         .ops = &jump_ops, },
>         { .name = "jae",        .ops = &jump_ops, },
>         { .name = "jb",         .ops = &jump_ops, },
> @@ -123,6 +125,8 @@ static struct ins x86__instructions[] = {
>         { .name = "test",       .ops = &mov_ops,  },
>         { .name = "testb",      .ops = &mov_ops,  },
>         { .name = "testl",      .ops = &mov_ops,  },
> +       { .name = "testq",      .ops = &mov_ops,  },
> +       { .name = "tzcnt",      .ops = &mov_ops,  },
>         { .name = "ucomisd",    .ops = &mov_ops,  },
>         { .name = "ucomiss",    .ops = &mov_ops,  },
>         { .name = "vaddsd",     .ops = &mov_ops,  },
> --
> 2.40.1.521.gf1e218fcd8-goog
>