linux-kernel - Re: [PATCH] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to uint32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b62a0db-1374-2c89-5ea3-286467bd1e4e@denx.de>
Date:   Mon, 15 May 2023 14:55:47 +0200
From:   Marek Vasut <marex@...x.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Richard Leitner <richard.leitner@...ux.dev>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     mike.looijmans@...ic.nl
Subject: Re: [PATCH] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to
 uint32

On 5/15/23 12:33, Krzysztof Kozlowski wrote:
> The "swap-dx-lanes" was never described as uint8 in original TXT
> bindings and Linuxx driver expects uint32.  Fix the type to match Linux

Linux , one x too many .

> driver expectation and original binding.
> 
> Fixes: fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Cc: mike.looijmans@...ic.nl
> ---
>   Documentation/devicetree/bindings/usb/usb251xb.yaml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb251xb.yaml b/Documentation/devicetree/bindings/usb/usb251xb.yaml
> index 4d1530816817..ac5b99710332 100644
> --- a/Documentation/devicetree/bindings/usb/usb251xb.yaml
> +++ b/Documentation/devicetree/bindings/usb/usb251xb.yaml
> @@ -231,7 +231,7 @@ properties:
>         power-on sequence to a port until the port has adequate power.
>   
>     swap-dx-lanes:
> -    $ref: /schemas/types.yaml#/definitions/uint8-array
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>       description: |
>         Specifies the ports which will swap the differential-pair (D+/D-),
>         default is not-swapped.

Would it make more sense to update the driver instead ? I doubt you 
could have more than 256 ports on this device after all.