linux-kernel - Re: [PATCH] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to uint32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da66656e-ddd6-99cf-41ee-d6b2d318bdff@topic.nl>
Date:   Mon, 15 May 2023 15:17:53 +0200
From:   <mike.looijmans@...ic.nl>
To:     Marek Vasut <marex@...x.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Richard Leitner <richard.leitner@...ux.dev>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to
 uint32

See below...

Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@...icproducts.com
W: www.topic.nl

Please consider the environment before printing this e-mail
On 15-05-2023 14:55, Marek Vasut wrote:
> On 5/15/23 12:33, Krzysztof Kozlowski wrote: diff --git 
> a/Documentation/devicetree/bindings/usb/usb251xb.yaml 
> b/Documentation/devicetree/bindings/usb/usb251xb.yaml
>> index 4d1530816817..ac5b99710332 100644
>> --- a/Documentation/devicetree/bindings/usb/usb251xb.yaml
>> +++ b/Documentation/devicetree/bindings/usb/usb251xb.yaml
>> @@ -231,7 +231,7 @@ properties:
>>         power-on sequence to a port until the port has adequate power.
>>       swap-dx-lanes:
>> -    $ref: /schemas/types.yaml#/definitions/uint8-array
>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>>       description: |
>>         Specifies the ports which will swap the differential-pair 
>> (D+/D-),
>>         default is not-swapped.
>
> Would it make more sense to update the driver instead ? I doubt you 
> could have more than 256 ports on this device after all.


I guess there's a bunch of devicetrees already out there using the 
(misdocumented) 32-bit array binding, they'd break in a bad way...


-- 
Mike Looijmans