linux-kernel - Re: [PATCH v2 1/2] dt-bindings: usb: Add microchip USB5807 HUB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12aa5eb5-77f4-0eb2-cc12-d9dbca0dbee7@topic.nl>
Date:   Mon, 15 May 2023 15:13:29 +0200
From:   Mike Looijmans <mike.looijmans@...ic.nl>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        devicetree@...r.kernel.org, linux-usb@...r.kernel.org
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: usb: Add microchip USB5807 HUB

See below (mailserver has a top-post fetish)


Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@...icproducts.com
W: www.topic.nl

Please consider the environment before printing this e-mail
On 15-05-2023 12:38, Krzysztof Kozlowski wrote:
> On 15/05/2023 08:25, Mike Looijmans wrote:
>> The USB5807 is a 7-port USB 3.1 hub that can be configured by I2C.
>
> Thank you for your patch. There is something to discuss/improve.
>
>> +
>> +  swap-dx-lanes:
>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>> +    maxItems: 8
> Missing minItems. Bug in the other binding caused this one to be hidden.

Will add "minItems: 0" in v3...

I initially based the code and binding on the usb251xb. Later found the 
mismatch and fixed it, but somehow forgot that I copied the "int8-array" 
too.

>
>> +    description:
>> +      Specifies the ports which will swap the differential-pair (D+/D-),
>> +      default is not-swapped.
>
> Best regards,
> Krzysztof
>

-- 
Mike Looijmans