linux-kernel - Re: [PATCH v3] gpio: sch311x: Use devm_gpiochip_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 May 2023 10:19:51 -0500
From:   Andrew Davis <afd@...com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Peter Tyser <ptyser@...-inc.com>,
        Andy Shevchenko <andy@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] gpio: sch311x: Use devm_gpiochip_add_data() to
 simplify remove path

On 5/15/23 4:08 PM, Andy Shevchenko wrote:
> On Mon, May 15, 2023 at 8:42 PM Andrew Davis <afd@...com> wrote:
>>
>> Use devm version of gpiochip add function to handle removal for us.
> 
> ...version of gpiochip_add() function...
> 
> ...
> 
>> +               err = devm_gpiochip_add_data(&pdev->dev, &block->chip, block);
>>                  if (err < 0) {
>>                          dev_err(&pdev->dev,
>>                                  "Could not register gpiochip, %d\n", err);
>> -                       goto exit_err;
>> +                       return err;
> 
> With this applied you can consider a followup to have this be converted to use
> 
>      return dev_err_probe(...);
> 
> here and in other ->probe() related pieces.
> 

Sure, I can add that cleanup to my list.

Or maybe Coccinelle can help do this everywhere, will have to look into that.

Andrew

>>                  }
>