linux-kernel - Re: [PATCH v2 3/3] PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 May 2023 01:19:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Thippeswamy Havalige <thippeswamy.havalige@....com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, krzysztof.kozlowski@...aro.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        bhelgaas@...gle.com, michals@...inx.com, robh+dt@...nel.org,
        nagaradhesh.yeleswarapu@....com, bharat.kumar.gogada@....com,
        lorenzo.pieralisi@....com,
        Thippeswamy Havalige <thippeswamy.havalige@....com>
Subject: Re: [PATCH v2 3/3] PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver

Hi Thippeswamy,

kernel test robot noticed the following build errors:

[auto build test ERROR on pci/next]
[also build test ERROR on pci/for-linus linus/master v6.4-rc2 next-20230516]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Thippeswamy-Havalige/Move-error-interrupt-bits-to-a-common-header/20230512-142845
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20230512062725.1208385-4-thippeswamy.havalige%40amd.com
patch subject: [PATCH v2 3/3] PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver
config: powerpc-allyesconfig
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project b0fb98227c90adf2536c9ad644a74d5e92961111)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc cross compiling tool for clang build
        # apt-get install binutils-powerpc-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/5a43e61aba650c8de2f2046f099732f6a14cecb9
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Thippeswamy-Havalige/Move-error-interrupt-bits-to-a-common-header/20230512-142845
        git checkout 5a43e61aba650c8de2f2046f099732f6a14cecb9
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305170035.0GpQpkHD-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/pci/controller/pcie-xdma-pl.c:494:8: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           val = FIELD_GET(XILINX_PCIE_DMA_IDRN_MASK,
                 ^
   1 error generated.


vim +/FIELD_GET +494 drivers/pci/controller/pcie-xdma-pl.c

   484	
   485	static void xilinx_pcie_dma_intx_flow(struct irq_desc *desc)
   486	{
   487		struct xilinx_pcie_dma *port = irq_desc_get_handler_data(desc);
   488		struct irq_chip *chip = irq_desc_get_chip(desc);
   489		unsigned long val;
   490		int i;
   491	
   492		chained_irq_enter(chip, desc);
   493	
 > 494		val = FIELD_GET(XILINX_PCIE_DMA_IDRN_MASK,
   495				pcie_read(port, XILINX_PCIE_DMA_REG_IDRN));
   496	
   497		for_each_set_bit(i, &val, PCI_NUM_INTX)
   498			generic_handle_domain_irq(port->leg_domain, i);
   499	
   500		chained_irq_exit(chip, desc);
   501	}
   502	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (337134 bytes)