[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOMZO5B0stW2X6YqPTTKDpCOAzPDvm=4HT8jfBAgbTy11gnKgg@mail.gmail.com>
Date: Tue, 16 May 2023 20:34:01 -0300
From: Fabio Estevam <festevam@...il.com>
To: Arnd Bergmann <arnd@...nel.org>, Martin Kaiser <martin@...ser.cx>
Cc: soc@...nel.org, Arnd Bergmann <arnd@...db.de>,
Russell King <linux@...linux.org.uk>,
Bartosz Golaszewski <brgl@...ev.pl>,
Hartley Sweeten <hsweeten@...ionengravers.com>,
Alexander Sverdlin <alexander.sverdlin@...il.com>,
Andre Przywara <andre.przywara@....com>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
NXP Linux Team <linux-imx@....com>,
Vladimir Zapolskiy <vz@...ia.com>,
Aaro Koskinen <aaro.koskinen@....fi>,
Janusz Krzysztofik <jmkrzyszt@...il.com>,
Tony Lindgren <tony@...mide.com>, Andrew Lunn <andrew@...n.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
Gregory Clement <gregory.clement@...tlin.com>,
Daniel Mack <daniel@...que.org>,
Haojian Zhuang <haojian.zhuang@...il.com>,
Robert Jarzmik <robert.jarzmik@...e.fr>,
Viresh Kumar <vireshk@...nel.org>,
Shiraz Hashim <shiraz.linux.kernel@...il.com>,
Sudeep Holla <sudeep.holla@....com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Alan Stern <stern@...land.harvard.edu>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-omap@...r.kernel.org, linux-clk@...r.kernel.org,
linux-usb@...r.kernel.org
Subject: Re: [PATCH 05/13] ARM: imx: remove unused mx25_revision()
Hi Arnd,
On Tue, May 16, 2023 at 12:32 PM Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> This function has no prototype and no callers:
>
> arm/mach-imx/cpu-imx25.c:43:5: error: no previous prototype for 'mx25_revision' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Martin Kaiser sent a patch adding a user for this function:
https://lore.kernel.org/linux-arm-kernel/20220815190748.102664-2-martin@kaiser.cx/
It would be better to apply Martin's patch instead of removing mx25_revision().
Thanks
Powered by blists - more mailing lists