linux-kernel - Re: [PATCH 05/13] ARM: imx: remove unused mx25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4e026f08-d733-4b01-ab47-e921d041e74e@app.fastmail.com>
Date:   Wed, 17 May 2023 08:39:53 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Fabio Estevam" <festevam@...il.com>,
        "Arnd Bergmann" <arnd@...nel.org>,
        "Martin Kaiser" <martin@...ser.cx>
Cc:     soc@...nel.org, "Russell King" <linux@...linux.org.uk>,
        "Bartosz Golaszewski" <brgl@...ev.pl>,
        "Hartley Sweeten" <hsweeten@...ionengravers.com>,
        "Alexander Sverdlin" <alexander.sverdlin@...il.com>,
        "Andre Przywara" <andre.przywara@....com>,
        "Shawn Guo" <shawnguo@...nel.org>,
        "Sascha Hauer" <s.hauer@...gutronix.de>,
        "Pengutronix Kernel Team" <kernel@...gutronix.de>,
        "NXP Linux Team" <linux-imx@....com>,
        "Vladimir Zapolskiy" <vz@...ia.com>,
        "Aaro Koskinen" <aaro.koskinen@....fi>,
        "Janusz Krzysztofik" <jmkrzyszt@...il.com>,
        "Tony Lindgren" <tony@...mide.com>, "Andrew Lunn" <andrew@...n.ch>,
        "Sebastian Hesselbarth" <sebastian.hesselbarth@...il.com>,
        "Gregory Clement" <gregory.clement@...tlin.com>,
        "Daniel Mack" <daniel@...que.org>,
        "Haojian Zhuang" <haojian.zhuang@...il.com>,
        "Robert Jarzmik" <robert.jarzmik@...e.fr>,
        "Viresh Kumar" <vireshk@...nel.org>,
        "Shiraz Hashim" <shiraz.linux.kernel@...il.com>,
        "Sudeep Holla" <sudeep.holla@....com>,
        "Lorenzo Pieralisi" <lpieralisi@...nel.org>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        "Michael Turquette" <mturquette@...libre.com>,
        "Stephen Boyd" <sboyd@...nel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Alan Stern" <stern@...land.harvard.edu>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        linux-clk@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 05/13] ARM: imx: remove unused mx25_revision()

On Wed, May 17, 2023, at 01:34, Fabio Estevam wrote:
> On Tue, May 16, 2023 at 12:32 PM Arnd Bergmann <arnd@...nel.org> wrote:
>>
>> From: Arnd Bergmann <arnd@...db.de>
>>
>> This function has no prototype and no callers:
>>
>> arm/mach-imx/cpu-imx25.c:43:5: error: no previous prototype for 'mx25_revision' [-Werror=missing-prototypes]
>>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Martin Kaiser sent a patch adding a user for this function:
>
> https://lore.kernel.org/linux-arm-kernel/20220815190748.102664-2-martin@kaiser.cx/
>
> It would be better to apply Martin's patch instead of removing mx25_revision().

I think either way is ok to address the warning. If we wanted to do this
properly, the mx{25,27,31,35,5}_revision functions could all be removed
and the logic hooked up to imx_set_soc_revision() in the same way that
they already use mxc_set_cpu_type() for drivers/soc/imx/soc-imx.c.

I'll leave it up to you, if you want to merge Martin's patches or
a replacement for the soc-imx driver through the imx tree for 6.5,
I'll drop my patch from this series, otherwise I'll keep it for now
and we can still do it better at later point.

    Arnd