linux-kernel - Re: [PATCH] gpu: drm: bridge: No need to set device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cb44d8c-eff9-33a5-7488-d79963806a91@linaro.org>
Date:   Tue, 16 May 2023 09:28:37 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Anup Sharma <anupnewsmail@...il.com>,
        Inki Dae <inki.dae@...sung.com>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Robert Foss <rfoss@...nel.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpu: drm: bridge: No need to set device_driver owner

On 13/05/2023 12:12, Anup Sharma wrote:
> There is no need to exclusively set the .owner member of the struct
> device_driver when defining the platform_driver struct. The Linux core
> takes care of setting the .owner member as part of the call to
> module_platform_driver() helper function.
> 
> Issue identified using the platform_no_drv_owner.cocci Coccinelle
> semantic patch as:
> drivers/gpu/drm/bridge/samsung-dsim.c:1957:6-11: No need to set .owner here.
> The core will do it.
> 
> No functional changes are intended.
> 
> Signed-off-by: Anup Sharma <anupnewsmail@...il.com>
> ---
>   drivers/gpu/drm/bridge/samsung-dsim.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
> index e0a402a85787..10dc3315e69e 100644
> --- a/drivers/gpu/drm/bridge/samsung-dsim.c
> +++ b/drivers/gpu/drm/bridge/samsung-dsim.c
> @@ -1954,7 +1954,6 @@ static struct platform_driver samsung_dsim_driver = {
>   	.remove = samsung_dsim_remove,
>   	.driver = {
>   		   .name = "samsung-dsim",
> -		   .owner = THIS_MODULE,
>   		   .pm = &samsung_dsim_pm_ops,
>   		   .of_match_table = samsung_dsim_of_match,
>   	},

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>