linux-kernel - Re: [PATCH] f2fs: flush error flags in workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 May 2023 18:46:56 +0800
From:   kernel test robot <lkp@...el.com>
To:     Chao Yu <yuchao0@...wei.com>, Chao Yu <chao@...nel.org>,
        jaegeuk@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, Chao Yu <yuchao0@...wei.com>,
        Chao Yu <chao@...nel.org>
Subject: Re: [PATCH] f2fs: flush error flags in workqueue

Hi Chao,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jaegeuk-f2fs/dev-test]
[cannot apply to jaegeuk-f2fs/dev linus/master v6.4-rc2 next-20230516]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chao-Yu/f2fs-flush-error-flags-in-workqueue/20230516-152832
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
patch link:    https://lore.kernel.org/r/20230516072755.3138097-1-chao%40kernel.org
patch subject: [PATCH] f2fs: flush error flags in workqueue
config: m68k-allyesconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/874c7ca40fa37e2697f9d2ac271147c5cafdddaa
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Chao-Yu/f2fs-flush-error-flags-in-workqueue/20230516-152832
        git checkout 874c7ca40fa37e2697f9d2ac271147c5cafdddaa
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash fs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305161802.YzwZE7UE-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/f2fs/super.c:4027:6: warning: no previous prototype for 'f2fs_record_errors' [-Wmissing-prototypes]
    4027 | void f2fs_record_errors(struct f2fs_sb_info *sbi, unsigned char error)
         |      ^~~~~~~~~~~~~~~~~~


vim +/f2fs_record_errors +4027 fs/f2fs/super.c

  4026	
> 4027	void f2fs_record_errors(struct f2fs_sb_info *sbi, unsigned char error)
  4028	{
  4029		int err;
  4030	
  4031		f2fs_down_write(&sbi->sb_lock);
  4032	
  4033		if (!f2fs_update_errors(sbi))
  4034			goto out_unlock;
  4035	
  4036		err = f2fs_commit_super(sbi, false);
  4037		if (err)
  4038			f2fs_err(sbi, "f2fs_commit_super fails to record errors:%u, err:%d",
  4039									error, err);
  4040	out_unlock:
  4041		f2fs_up_write(&sbi->sb_lock);
  4042	}
  4043	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (289819 bytes)