linux-kernel - Re: [PATCH 0/2] KVM support for Intel PMU v5 fixed function PMC bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d7f7f80-278d-9fcf-cfc4-c433e95d9842@gmail.com>
Date:   Tue, 16 May 2023 21:29:07 +0800
From:   Like Xu <like.xu.linux@...il.com>
To:     Anselm Busse <abusse@...zon.com>
Cc:     dwmw@...zon.co.uk, hborghor@...zon.de, sironi@...zon.de,
        Sean Christopherson <seanjc@...gle.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] KVM support for Intel PMU v5 fixed function PMC
 bitmap

On 27/4/2023 5:53 pm, Anselm Busse wrote:
> Starting with v5, the Intel PMU allows to indicate the available fixed
> function PMCs not only through CPUID.0AH.EDX[4:0] but also through a
> bit mask in CPUID.0AH.ECX. According to the SDM the OS can consider a
> fix function PMC i supported for:
> 
> CPUID.0AH.ECX[i] || (CPUID.0AH.EDX[4:0] > i)

Yes, this feature is attractive for virtualization scenarios, and it gives 
flexibility
to control which fixed counters are available or not in the virtual machine.

However, currently KVM/x86 also supports Intel PMU V2, so I would expect
that we will review the enablement code for v3 and v4 first.

Ref: 
https://lore.kernel.org/kvm/CALMp9eQVnk8gkOpX5AHhaCr8-5Fe=qNuX8PUP1Gv2H5FSYmHSw@mail.gmail.com/

> 
> This behavior is already supported by the Intel PMU driver. However, KVM
> support is missing. This patch series add the support by first
> refactoring the tracking of available fixed function PMCs in KVM from a
> number to a bitmap in the frist patch. The second patch populates the
> bitmap accoring to the rule given by the SDM mentioned above.
> 
> Regards,
> Anselm
> 
> Anselm Busse (2):
>    KVM: vmx/pmu: Indicate available fixed function PMCs through a bitmap
>    KVM: vmx/pmu: Add support for selected fixed vPMU enablement for PMU v5
> 
>   arch/x86/include/asm/kvm_host.h |  2 +-
>   arch/x86/kvm/pmu.h              |  6 ++---
>   arch/x86/kvm/svm/pmu.c          |  2 +-
>   arch/x86/kvm/vmx/pmu_intel.c    | 40 ++++++++++++++++++++-------------
>   4 files changed, 30 insertions(+), 20 deletions(-)
> 
> 
> base-commit: 0cfd8703e7da687924371e9bc77a025bdeba9637